Repository navigation
ci: apply the repo standard (EN-214) - #3
Merged
Merged
Conversation
corypride
requested changes
Nov 7, 2026
corypride
left a comment
corypride
left a comment
Contributor
There was a problem hiding this comment.
@CK-7vn I checked the workflow files against contracts #9 and provider-platforms #3, the protect-main ruleset, the pins, and the README against #2.
- The ruleset still requires
conventional. (High) This PR reportsconventional commits(conventional-commits.yml:15), so it stays blocked until the ruleset's name is swapped. Swap it when this merges, and only after #2 and itsrelease 0.1.0PR are in, since both still reportconventional. - README.md conflicts with #2. (Medium) #2 rewrites the README, including the commit-types section this PR edits. After rebasing on #2, its
README.md:149still saysconventionaland should sayconventional commits. - Missing
git rev-listguard. (Nit) contracts #9 checks the range first (ci.yml:51-52), so a bad range fails instead of passing silently. Worth the same line here.
Will approve once rebased on #2 with the README fixed.
# Conflicts: # README.md
corypride
approved these changes
Nov 10, 2026
corypride
left a comment
corypride
left a comment
Contributor
There was a problem hiding this comment.
@CK-7vn Re-checked at 4cc48a4. Both of my earlier points are fixed.
- The merge with main is clean. The PR now touches only the 5 CI/template files plus a one-line README change at
README.md:149(conventional commits). Nothing from #2 is lost, and.release-please-manifest.json(0.1.0) and the release-please config match main. - The
rev-listguard and theeditedtrigger are in (conventional-commits.yml:7-8,:28-29). Every workflow has a top-levelpermissions:block. - Nit:
pr-title.yml:3is over 80 columns. Optional.
APPROVE. The ruleset still requires conventional, so I will swap it to conventional commits right before merging and merge straight after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Part of EN-214: one repo standard across every UnlockEd repo (
docs/repo-standard.mdin unlocked-core). This repo was made fromunlocked-product-template, which gets the same change.commits.yml(webiny action, jobconventional, on push and pull_request) is replaced byconventional-commits.yml, the shared inline check every UnlockEd repo now runs:pull_requestonly, every non-merge commit, same 11 types. GitHub's Revert button writesRevert "...", which fails; the check prints the conventional rewording (revert: ...).conventional commits.Merge order (the ruleset still requires the old check name
conventional): this PR shows that check as missing. Once checks are green and it is approved, switch this repo'sprotect-mainruleset toconventional commits(stage/putin core'sdocs/repo-standard.md), merge, then ask authors of open PRs to rebase.Release
ci).